Update JsonToStructs and ScanJson to have white space normalization #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
build |
|
build |
jlowe
previously approved these changes
Mar 14, 2024
| def deepTransformView(cv: ColumnView, dt: Option[DataType] = None) | ||
| def deepTransformView(cv: ColumnView, dt: Option[DataType] = None, | ||
| nestedMismatchHandler: Option[(ColumnView, DataType) => | ||
| (Option[ColumnView], ArrayBuffer[AutoCloseable])] = None) |
There was a problem hiding this comment.
Does the handler need to return a mutable ArrayBuffer? I think the handler could return an immutable Seq given how it's being used, and that seems more flexible and less error-prone than forcing an ArrayBuffer here.
|
build |
|
@jlowe please take another look |
jlowe
reviewed
Mar 14, 2024
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuJsonReadCommon.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/ColumnCastUtil.scala
Outdated
Show resolved
Hide resolved
|
build |
|
@jlowe please take another look |
jlowe
approved these changes
Mar 15, 2024
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contributes to #10491 in a very small way by adding in a few more tests.
Mostly it turns on white space normalization and tries to verify that it is doing the right thing, but there were some errors, so I filed more issues.